Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

De namespace #67

Merged
merged 3 commits into from
Jan 23, 2023
Merged

De namespace #67

merged 3 commits into from
Jan 23, 2023

Conversation

taldcroft
Copy link
Member

Description

Remove namespace package following the formalism in sot/ska_sun#22.

Interface impacts

None

Testing

Unit tests

  • Mac

Functional tests

  • Installed and ran tests for both versions
  • Built docs and confirmed they look reasonable

javierggt
javierggt approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also ran tests and built docs.

@taldcroft taldcroft merged commit 763e06e into master Jan 23, 2023
@taldcroft taldcroft deleted the de-namespace branch January 23, 2023 18:02
@javierggt javierggt mentioned this pull request Jan 23, 2023
Closed
@javierggt javierggt mentioned this pull request Mar 13, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@javierggt javierggt javierggt approved these changes

@jeanconn jeanconn Awaiting requested review from jeanconn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @javierggt