-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Telescope Bus 5 and Bus 6 state to calculate relevant derived thermal parameters #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! I just have a suggestion that might simplify the logic if I have gotten it right.
This will need at least some testing similar to standalone testing at the function level that you've done before. There should be an obvious change in the P50 (zone 50) value during the test intervals. |
Modify the `data[msid].vals` array in place rather than redefining it, to account for bus 5 and bus 6 state. Co-authored-by: Tom Aldcroft <taldcroft@gmail.com>
I completed some testing by redefining the |
There's another update I may tack on to this PR. The DP_HADG calculation in cheta is incorrect does not match what is in G_TREND24 and MAUDE, so I am generating an update to fix this. |
@taldcroft The HADG fix has been posted, and passes my local test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now and testing is completed.
Thank You! |
Description
The heater zones within the Telescope Bus 5 and Bus 6 cannot be commanded if either of these busses are disabled, such as when the Telescope Bus 6 is disabled to turn off the stuck on Zone 50 heater. From what I can tell, the bilevel heater telemetry for these zones does not depend on bus state, but rather commanding from the OBC, so if a temperature were to drop below the heater set point within a zone in Bus 5 or Bus 6, the relevant bilevel MSID would likely falsely indicate the heater is ON.
This update uses the Telescope Bus 5 and Bus 6 state to correct any false Telescope Bus 5 or Bus 6 bilevel telemetry, including within Zone 50.
Testing
Functional testing
Local testing of functions (@matthewdahmer )
I completed some testing by redefining the DerivedParameterThermal and affected classes locally (in a notebook), and was able to confirm that the code functions as expected in this context, resulting in a drop in zone 50 power to zero when the Telescope Bus 6 is disabled.
Testing within update processing code on HEAD (@taldcroft)
After checking out this branch on HEAD:
This ran to completion with no errors, indicating that the derived parameter code updates are running. Functional testing that the values are correct was done with the local testing.