Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pickling for MSIDset and add tests #226

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Fix pickling for MSIDset and add tests #226

merged 1 commit into from
Mar 9, 2022

Conversation

taldcroft
Copy link
Member

Description

This fixes a problem when unpickling an MSIDset and adds tests for both that class and MSID.

Testing

  • Passes unit tests on MacOS
  • [n/a] Functional testing

@jeanconn
Copy link
Contributor

jeanconn commented Mar 9, 2022

It wasn't clear what the original problem was to me from the description, so I ran the new tests on the old code to see

>       dat2 = pickle.loads(pickle.dumps(dat))
E       TypeError: __init__() missing 1 required positional argument: 'msids'

Ska/engarchive/tests/test_fetch.py:91: TypeError

And I see that this goes away with the bugfix.

@taldcroft taldcroft merged commit a4cfbea into master Mar 9, 2022
@taldcroft taldcroft deleted the fix-pickle branch March 9, 2022 18:07
@javierggt javierggt mentioned this pull request Mar 30, 2022
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants