test_ra_dec_roll still failing

[jeanconn]

test_ra_dec_roll still failing.

I think for the case where there are no Constraints that no date is supplied here in get_star and the stars are moving.

find_attitude/find_attitude/find_attitude.py

Line 773 in a364d50

agasc_stars = [agasc.get_star(agasc_id, date=date) for agasc_id in agasc_ids]

That suggests to me that if we just want to fix the test, we'd either need to open up the tolerances of the test or use mock to replace agasc.get_star with a mocked version that takes a pinned/fixed date. Otherwise find_attitude would need a new date to get through to here that isn't the Constraint date. I think.

[taldcroft]

Otherwise find_attitude would need a new date to get through to here that isn't the Constraint date.

The Constraint date is indeed the way to constrain the date to a particular value. This is slightly unintuitive, but the alternative of providing a new date kwarg to find_attitude_solutions was worse because there would be two dates in the API.

[jeanconn]

That's fine. I thought the point of that test was to run in an un-Constraint-ed way, but if it is fine to add one that's great.