Make commands v2 the default #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
51 tasks
|
Did the docs lose the a breadcrumb to set to v1 with commands.conf.commands_version = "1"? |
taldcroft
force-pushed
the
commands-v2-default
branch
from
3df9587 to
89ae898
Compare
|
@jeanconn - I rebased to fix the merge conflicts and re-ran unit tests with no failures. I also added a docs file |
jeanconn
approved these changes
Sep 27, 2022
taldcroft
added a commit
that referenced
this pull request
Apr 24, 2023
Factor out `get_ofp_states` and `get_telem_values` for cheta #249 improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes commands v2 the default and thus v1 is now the backup.
Interface impacts
There are API changes that have been widely discussed in informational forums. In particular getting commands may try using network resources by default.
The new version of commands archive files generated with PR #248 should be installed into
$SKA/data/kadion HEAD when kadi commands v2 is promoted via a new ska3-flight release. Those files are in/home/aldcroft/tmp/kadion HEAD.Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.