Compare regression test quaternions with delta-quat tolerance check #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
reviewed
Jun 26, 2023
jeanconn
changed the title
taldcroft
approved these changes
Jun 26, 2023
|
Yes - that was what I tested before moving this from non-WIP status and asking for review. |
|
Honestly, I hadn't run the tests on kady, so I'll leave that as an exercise for integration testing. |
This was referenced Jul 12, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compare regression test quaternions with delta-quat tolerance check instead of == test.
This fixes the issue that the calculated quaternions on fido present insignificant numeric differences from the same quaternions calculated on kady.
Interface impacts
Testing
Unit tests
Independent check of unit tests by @taldcroft
Functional tests
No functional testing.