Use vectorized Quat #241
Merged
Use vectorized Quat #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
reviewed
Sep 29, 2020
jeanconn
force-pushed
the
vectorized_quat
branch
from
52f8339 to
e237e20
Compare
|
In mica, with these changes, I think we're just left with a call to mica.quaterion in the mica.web.pcad_table app. I think that's still run from the Python 2 kadi server? I don't know when we'd plan to update that kind of thing or pull out of mica and put in a web-apps area. |
jeanconn
force-pushed
the
vectorized_quat
branch
from
e237e20 to
64df8b5
Compare
jeanconn
commented
Dec 22, 2020
This was referenced Jan 4, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use modern vectorized Quaternion.Quat instead of mica.quaterion
Testing
Did not do additional function testing except for spot-checking a few of the intermediate matrices to see if they looked reasonable compared to master.
Fixes #