Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report generation likely to generate bad paths on Windows #251

Open
taldcroft opened this issue Jan 29, 2019 · 2 comments
Open

Report generation likely to generate bad paths on Windows #251

taldcroft opened this issue Jan 29, 2019 · 2 comments
Labels
bug Something isn't working priority-low

Comments

@taldcroft
Copy link
Member

See sot/sparkles#21

@taldcroft taldcroft added the bug Something isn't working label Jan 29, 2019
@taldcroft taldcroft modified the milestone: 4.3.3 Jan 29, 2019
@taldcroft
Copy link
Member Author

I looked into the HTML output and source code and templates. For default usage (in particular the way report generation gets called from aca_preview) there is not a problem here. If rootdir is more than one dir deep then problems could happen.

For reference the right way to ensure correct POSIX-ness is to use the to_posix() method on a Path (which might be a WindowsPath).

@taldcroft taldcroft added this to the 4.4 milestone Feb 6, 2019
@taldcroft
Copy link
Member Author

I'm removing this from the 4.4 milestone because the current baseline process for use on Windows does not include proseco acq or guide report generation. The interface to sparkles always uses report_level='none', and there is no strong driver for FOT to be running this. So this is still out there but not a high priority.

@taldcroft taldcroft removed this from the 4.4 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low
Projects
None yet
Development

No branches or pull requests

1 participant