Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying get_sun_pitch_yaw coordinate convention and change default #30

Closed
taldcroft opened this issue Mar 2, 2023 · 1 comment · Fixed by #37
Closed

Allow specifying get_sun_pitch_yaw coordinate convention and change default #30

taldcroft opened this issue Mar 2, 2023 · 1 comment · Fixed by #37

Comments

@taldcroft
Copy link
Member

taldcroft commented Mar 2, 2023

The current definition of yaw about the sun line matches ORviewer, but this does not match the engineering convention where +yaw is in the same sense as spacecraft body yaw.

The new default should match the engineering sense, go from 0 to 360, and have zero be defined as the ECI z-axis if the Sun is at exactly RA = Dec = 0.

Add a keyword argument coord_system which can take the values "spacecraft" or "ORviewer".

@taldcroft taldcroft changed the title Change get_sun_pitch_yaw coordinate convention Allow specifying get_sun_pitch_yaw coordinate convention and change default Mar 2, 2023
@jeanconn jeanconn self-assigned this Apr 3, 2023
@jeanconn
Copy link
Contributor

I had this on my plate but just realized my understanding is not lining up with "have zero be defined as the ECI z-axis" as I thought yaw=0 would define the placement of X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants