Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions to ska packages #295

Closed
42 of 47 tasks
javierggt opened this issue Feb 6, 2020 · 13 comments
Closed
42 of 47 tasks

Add github actions to ska packages #295

javierggt opened this issue Feb 6, 2020 · 13 comments

Comments

@javierggt
Copy link
Contributor

javierggt commented Feb 6, 2020

As the title says: we will be adding automated actions to ska packages, and this is the uber-issue.

Changes should include:

  • building in CentOS 5 (all packages) and Mac OS (some packages). This will run whenever there is a push to master or a release is created. Resulting conda packages are uploaded to Google drive.
  • automatically edit release descriptions to include latest PRs. This is done when a release is created.
  • automatically open an issue labeled "Package Update" in sot/skare3. Also when a release is created. This could be when a release is published instead.
  • a pull request template (Make a pull request template in every Ska3 project repo #293)

I will first add Chandra.Time for you to check. Then I will add the rest. The list of packages is:

  • Chandra.Maneuver
  • Chandra.Time (macos + linux)
  • Quaternion
  • Ska.DBI
  • Ska.File
  • Ska.Matplotlib
  • Ska.Numpy (macos + linux)
  • Ska.ParseCM
  • Ska.Shell
  • Ska.Sun
  • Ska.arc5gl
  • Ska.astro
  • Ska.ftp
  • Ska.quatutil
  • Ska.tdb
  • acdc
  • agasc
  • annie
  • chandra_aca
  • cmd_states
  • cxotime
  • eng_archive
  • hopper
  • kadi
  • maude
  • mica
  • parse_cm
  • proseco
  • pyyaks
  • ska_helpers
  • ska_path
  • ska_sync
  • sparkles
  • starcheck
  • tables3_api
  • taco (macos + linux)
  • task_schedule (macos + linux)
  • testr
  • xija (macos + linux)
  • sot/aca_egse
  • sot/watch_cron_logs

NOTE the ones missing in the list above
ACIS ops:

  • acisops/acis_thermal_check
  • acisops/acisfp_check
  • acisops/backstop_history
  • acisops/dea_check
  • acisops/dpa_check
  • acisops/psmc_check
This was referenced Feb 6, 2020
@javierggt
Copy link
Contributor Author

javierggt commented Feb 7, 2020

@jeanconn, would you mind merging the PRs for a couple of packages you intend to release today? (if any). Quaternion, for example.

After you agree, that is.

@jeanconn
Copy link
Contributor

jeanconn commented Feb 7, 2020

Per our conversation, none of these are going today, but Quaternion will probably go next week if we want to start with that as a dog fooding test case.

@javierggt
Copy link
Contributor Author

I am about to add github actions to acis packages. @jzuhone do you also want the PR template Tom requested? (#293)

@jzuhone
Copy link
Collaborator

jzuhone commented Feb 13, 2020

@javierggt yes, that'd be great

@javierggt
Copy link
Contributor Author

there is also an action that edits the release notes to mention all merges since last release. That one works in test repositories, but I do not know if it works fine everywhere.

@jeanconn
Copy link
Contributor

Since we can still edit the release notes, I think it is benign if it isn't perfect yet.

@javierggt
Copy link
Contributor Author

@jzuhone I can't push a branch to the repositories.

@jeanconn
Copy link
Contributor

They generally do PRs from their own forks which I think you could do too in this case @javierggt ?

@jzuhone
Copy link
Collaborator

jzuhone commented Feb 13, 2020

@javierggt which repo did you try?

@jzuhone
Copy link
Collaborator

jzuhone commented Feb 13, 2020

@javierggt try now.

@javierggt
Copy link
Contributor Author

I just noticed that sot/find_attitude is not included here. It should be, shouldn't it?

@jeanconn
Copy link
Contributor

Yes. I'm not sure about the best way to check for any other missing ones but assume we'll notice if we just have missing automatic builds for a dependency.

@javierggt
Copy link
Contributor Author

javierggt commented Feb 18, 2020

I noticed by creating a ska3-dev environment including this channel: https://cxc.cfa.harvard.edu/mta/ASPECT/ska3-conda/dev

The only ska3-dev package not coming from this channel was find_attitude (and the acisops packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants