Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing pyqt in ska3-core-latest? #969

Closed
jskrist opened this issue Nov 15, 2022 · 3 comments
Closed

missing pyqt in ska3-core-latest? #969

jskrist opened this issue Nov 15, 2022 · 3 comments
Labels
Milestone

Comments

@jskrist
Copy link
Member

jskrist commented Nov 15, 2022

the ska3-core package contains pyqt, but the ska3-core-latest does not. It's possible that this is by design, but it caused an issue in the Python trunk area on windows. pyqt was not being updated because the conda update command was referencing the ska3-core-latest package.

@javierggt
Copy link
Contributor

yes, this might be a bug. I have to admit that we never test ska3-latest, but I guess we should, because it often is not right.

The test should be that replacing ska3-core by ska3-core-latest should be a no-op (so this ticket is the partner of #967)

@javierggt javierggt added the bug label Nov 16, 2022
@javierggt javierggt added this to the ska3-prime milestone Jan 17, 2023
@javierggt
Copy link
Contributor

javierggt commented Jan 19, 2023

I just checked this while preparing the new large Ska update.

Indeed PyQt is not listed in ska3-core-latest, but it ends up being installed because pyqtgraph is listed.

I am adding PyQt to the list, but I am not sure that this is necessary. It seems to me that your issue was trying to update ska3-core-latest. Ska3-core-latest indeed had not changed, so the update behavior is to not update dependencies. If one wants to update dependencies, I believe one has to give the option --update-all to conda update. If instead one gives the --update-deps option, then pyqt would only update the explicit dependencies (was this the option you were using?).

Anyway, future versions will have this, but there are other packages that are not explicitly listed.

@javierggt
Copy link
Contributor

Fixed in 2023.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants