Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACQ box with fid light in the box maybe should be orange warning? #243

Open
jeanconn opened this issue May 7, 2018 · 7 comments
Open

ACQ box with fid light in the box maybe should be orange warning? #243

jeanconn opened this issue May 7, 2018 · 7 comments

Comments

@jeanconn
Copy link
Contributor

jeanconn commented May 7, 2018

No description provided.

@jeanconn
Copy link
Contributor Author

This should be an orange warning (as the issue text indicates) and it also might make sense to adjust the acquisition probability for the box to 0 so that the overall acq probability doesn't count the acq star that would be very likely to be spoiled by the fid. Then we'd get a failing acq probability in the summary if the spoiled star really mattered.

@jeanconn
Copy link
Contributor Author

The warning for a fid light in a BOT box should continue to be a red warning (Critical) but could also have this probability adjustment if we go that way.

@taldcroft
Copy link
Member

Agree fully with the first comment.

I'm confused about the red warning for a fid light in a BOT box. I assume that is a warning on the fid? I don't see why being in a BOT/ACQ box matters for a fid, since fid search happens after acquisition and with a small (25") box. The main issue is whether the star might spoil fid acquisition if the maneuver error is large enough. That depends on the man err and relative mags.

@jeanconn
Copy link
Contributor Author

Yes, the red warning is supposed to be for the FID. I was under the impression that the small (25") box for the fid search is irrelevant, because if the the fid is in a BOT box, first it spoils the acquisition, but then it stays tracked in the box as the BOT star, because there is no new search on a BOT. Fid search then fails because those pixels are already being tracked. See "Failed fid acquisition in Obsid 14577". I think this still might be a reason to stop using BOT stars (and always re-search).

@taldcroft
Copy link
Member

Right, excellent point, thanks for reminding me.

Changing how we normally command star catalogs is a different and bigger question which would benefit from full SSAWG participation. I think that warnings in starcheck largely mitigate the 14577 problem, and so we need to fully understand the other benefits / risks.

@jeanconn
Copy link
Contributor Author

Changing how we normally command star catalogs is a different and bigger question which would benefit from full SSAWG participation.

Indeed. We started to talk about this at one point with regard to changing MAXMAG, but I didn't find that the data supported the idea that refining MAXMAG would give us a big improvement in tracking performance. I just brought it up in this thread because it would fix this particular problem and it is worth keeping the idea of independently commanding ACQ and GUI in our box of tricks when looking at other issues.

@jeanconn
Copy link
Contributor Author

Also, upon reflection I suppose "Yes, the red warning is supposed to be for the FID" is true but I suppose losing the guide star is worth the red warning too, so this issue would basically be worth 2 red warnings.

@jeanconn jeanconn added this to the 13.1 milestone Jan 17, 2019
@jeanconn jeanconn modified the milestones: 13.1, 13.2 Mar 20, 2019
@jeanconn jeanconn removed this from the 13.3 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants