Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust / verify fid light checks to match proseco #269

Open
taldcroft opened this issue Dec 18, 2018 · 1 comment
Open

Adjust / verify fid light checks to match proseco #269

taldcroft opened this issue Dec 18, 2018 · 1 comment

Comments

@taldcroft
Copy link
Member

Making sure that starcheck matches proseco for some of these simple "box" checks is also a good opportunity for independent code / algorithm review.

Fid spoils acq: https://github.com/sot/proseco/blob/bb3bc560a53d83333914090cc3216e340b1e7aff/proseco/fid.py#L243

Star spoilers fid:
https://github.com/sot/proseco/blob/bb3bc560a53d83333914090cc3216e340b1e7aff/proseco/fid.py#L352

Off-CCD:
https://github.com/sot/proseco/blob/bb3bc560a53d83333914090cc3216e340b1e7aff/proseco/fid.py#L315

Near hot or bad pixel:
https://github.com/sot/proseco/blob/bb3bc560a53d83333914090cc3216e340b1e7aff/proseco/fid.py#L329
@taldcroft taldcroft added this to the 13.0 proseco milestone Dec 18, 2018
@taldcroft taldcroft modified the milestones: 13.0 proseco, 13.1 Jan 17, 2019
@taldcroft
Copy link
Member Author

Re-milestoned for 13.1 to do detailed algorithm review.

Code review of changes for 13.0 related to fid checks (off-CCD, hot pixels) is sufficient for the 13.0 release.

@jeanconn jeanconn modified the milestones: 13.1, 13.2 Mar 20, 2019
@jeanconn jeanconn removed this from the 13.3 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taldcroft @jeanconn