Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run correctly in root or env conda environment #312

Closed
jeanconn opened this issue Jun 11, 2019 · 2 comments
Closed

Run correctly in root or env conda environment #312

jeanconn opened this issue Jun 11, 2019 · 2 comments

Comments

@jeanconn
Copy link
Contributor

Run correctly in root or env conda environment. See

#302 (comment)

and following comments. This may end up being a skare3 issue, but I'm going to track it here for now.

@taldcroft
Copy link
Member

AFAIK (and this could easily be wrong), starcheck is the only Ska3 app that needs a SKA_ROOT. Some ideas to discuss:

  1. Define SKA_ROOT on-the-fly in starcheck/src/starcheck as below. Not clear if this is robust or if there is a more elegant way.
PYTHON_EXE=`which python`
SKA_BIN=`dirname $PYTHON_EXE`
SKA_ROOT=`dirname $SKA_BIN`
  1. Define $CONDA_PREFIX in ska_envs.* so that this guaranteed to be defined in both "production" and "standalone env" environments. I'm less keen on this.
  2. Is there some post-activate conda hook we can use to define SKA_ROOT?

If (1) works and there are no other applications that need SKA_ROOT then I'd vote for that.

@jeanconn
Copy link
Contributor Author

I think this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants