Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of deprecated np.int #21

Merged
merged 2 commits into from
Jan 12, 2022
Merged

remove use of deprecated np.int #21

merged 2 commits into from
Jan 12, 2022

Conversation

javierggt
Copy link
Contributor

Description

This PR makes tiny changes to remove uses of a few deprecated dtypes (sot/skare3#753)

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required). Also checked that warning appears in tests before changes.
  • Functional testing

Fixes #

@javierggt javierggt merged commit dae1be0 into master Jan 12, 2022
@javierggt javierggt mentioned this pull request Jan 18, 2022
Closed
@javierggt javierggt deleted the deprecated-np-types branch January 18, 2022 19:49
@javierggt javierggt mentioned this pull request Feb 8, 2022
Merged
3 tasks
@javierggt javierggt mentioned this pull request May 18, 2022
Closed
@javierggt javierggt mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

@jeanconn jeanconn Awaiting requested review from jeanconn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierggt @taldcroft