Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The class name "AcisDpaStatePower" is misleading #42

Open
jzuhone opened this issue Jul 15, 2016 · 0 comments
Open

The class name "AcisDpaStatePower" is misleading #42

jzuhone opened this issue Jul 15, 2016 · 0 comments

Comments

@jzuhone
Copy link
Collaborator

jzuhone commented Jul 15, 2016

All of the ACIS thermal models include some thermal contribution from ACIS electronics that depends on: number of chips, FEPs, are we clocking or not, are the video boards powered or not.

The name for this class is AcisDpaStatePower, which is a bit misleading when applied to the models besides the one for the DPA. This caused a bit of trouble the other day when I was trying to interpret the modeled state power in the DEA model and was thinking about the power from the DPA (my fault, of course).

I would suggest renaming it to AcisStatePower, but that would necessitate re-naming the class name in the JSON files as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant