Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send dt printing to logger #74

Closed
jeanconn opened this issue Jan 24, 2020 · 6 comments
Closed

send dt printing to logger #74

jeanconn opened this issue Jan 24, 2020 · 6 comments

Comments

@jeanconn
Copy link
Contributor

Not really an issue, but I note that there's a lot of printing of the dt during the module tests:

xija/tests/test_models.py::test_dpa Using dt = 328 s.
PASSED
xija/tests/test_models.py::test_plotdate Using dt = 328 s.
PASSED
xija/tests/test_models.py::test_data_types Using dt = 328 s.
Using dt = 328 s.
Using dt = 328 s.
Using dt = 328 s.
Using dt = 328 s.
Using dt = 328 s.
Using dt = 328 s.
PASSED
xija/tests/test_models.py::test_minusz Using dt = 328 s.
PASSED
xija/tests/test_models.py::test_pftank2t Using dt = 328 s.
PASSED
xija/tests/test_models.py::test_multi_solar_heat_values Using dt = 328 s.
Using dt = 328 s.
PASSED

Originally posted by @jeanconn in #48 (comment)

@jeanconn
Copy link
Contributor Author

jeanconn commented Feb 3, 2020

@matthewdahmer it sounds like if this is having an impact for you priority is higher.

@jzuhone
Copy link
Collaborator

jzuhone commented Feb 3, 2020

@jeanconn this is fixed in PR #75.

@jeanconn
Copy link
Contributor Author

jeanconn commented Feb 3, 2020

Thanks @jzuhone. I just wasn't sure when we were going to get a chance to review and run with #75. It sounds like from @matthewdahmer 's notes that he can work around if this doesn't go this week.

@matthewdahmer
Copy link
Contributor

Thank you I do have a workaround where I can use an older version of Xija to produce the data I need, however this bug otherwise would have a significant impact.

@jzuhone
Copy link
Collaborator

jzuhone commented Apr 23, 2020

This issue can be closed now.

@jeanconn
Copy link
Contributor Author

Closed by #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants