Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check action design consistency (Chess, Shogi, AnimalShogi) #876

Open
sotetsuk opened this issue May 17, 2023 · 2 comments
Open

Check action design consistency (Chess, Shogi, AnimalShogi) #876

sotetsuk opened this issue May 17, 2023 · 2 comments

Comments

@sotetsuk
Copy link
Owner

sotetsuk commented May 17, 2023

Is it easy to recover the square info with same operation?

  • Animal Shogi: x, sq = jnp.int8(a // 12), jnp.int8(a % 12)
  • Chess: from_, plane = label // 73, label % 73 (consistent to OpenSpiel)
  • Shogi: direction, to = jnp.int8(action // 81), jnp.int8(action % 81) (consistent to dlshogi)

Also, write these info to docs.

@sotetsuk
Copy link
Owner Author

Seems sq = label % boardsize is natural? (considering Go and Hex)

@sotetsuk
Copy link
Owner Author

Fixing the implementation is impossible. So, prepare get_board_position(label), get_plane(label) or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant