Use Swift Concurrency instead of Dispatch #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moved json loading inside of task group to speed things up a bit
0xTim
approved these changes
Aug 14, 2023
adam-fowler
added a commit
that referenced
this pull request
Oct 4, 2023
Also moved json loading inside of task group to speed things up a bit
adam-fowler
added a commit
that referenced
this pull request
Dec 4, 2023
Also moved json loading inside of task group to speed things up a bit
adam-fowler
added a commit
that referenced
this pull request
Apr 6, 2024
Also moved json loading inside of task group to speed things up a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of service files is done inside a ThrowingTaskGroup instead of a DispatchGroup.
Also moved loading of Smithy JSON AST into ThrowingTaskGroup to give us a little more performance