Remove chars "@()" from s3PathAllowedCharacters (#604)

* Remove chars "@()" from s3PathAllowedCharacters

Some non AWS S3 systems do not cope with non percent encoded version of these characters

* Update s3 allowed characters
To include all characters that might require special handling

* More characters

Sources/Soto/Extensions/S3/S3RequestMiddleware.swift

@@ -101,10 +101,10 @@ public struct S3RequestMiddleware: AWSServiceMiddleware {
         }
     }
 
-    static let pathAllowedCharacters = CharacterSet.urlPathAllowed.subtracting(.init(charactersIn: "+"))
+    static let s3PathAllowedCharacters = CharacterSet.urlPathAllowed.subtracting(.init(charactersIn: "+@()&$=:,'!*"))
     /// percent encode path value.
     private static func urlEncodePath(_ value: String) -> String {
-        return value.addingPercentEncoding(withAllowedCharacters: Self.pathAllowedCharacters) ?? value
+        return value.addingPercentEncoding(withAllowedCharacters: Self.s3PathAllowedCharacters) ?? value
     }
 
     func createBucketFixup(request: inout AWSRequest) {

Tests/SotoTests/Services/S3/S3Tests.swift

@@ -165,6 +165,13 @@ class S3Tests: XCTestCase {
                 XCTAssertEqual(response.body?.asString(), contents)
                 XCTAssertNotNil(response.lastModified)
             }
+            .flatMap { _ -> EventLoopFuture<S3.ListObjectsV2Output> in
+                return Self.s3.listObjectsV2(.init(bucket: name))
+            }
+            .map { result in
+                let contents = result.contents
+                XCTAssertNotNil(contents?.first(where: { $0.key == filename }))
+            }
             .flatAlways { _ in
                 return Self.deleteBucket(name: name, s3: Self.s3)
             }