Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving the mouse cursor to the top right corner doesn't highlight the close button #112

Closed
MooseZM opened this issue Jul 20, 2024 · 4 comments

Comments

@MooseZM
Copy link

MooseZM commented Jul 20, 2024

As the title implies, moving the cursor to the very top right corner doesn't highlight the close button, like there's an empty space there. On a similar note, moving the cursor to the left edge of the screen doesn't expand the tabs, you have to move a few pixels to the right for it to expand (again like there's an empty space). Here's a video that might explain it better.

out.1.mp4
@soulhotel
Copy link
Owner

That's intentional design, the tabs panel doesn't sit at the screen, the window positioning would look unnatural if it did. But you can toggle ultima.xstyle.squared to remove the tab spacing and expand on the very far corners.

  • ultima.xstyle.squared off
    2024-07-19_20-43_1

  • ultima.xstyle.squared on
    2024-07-19_20-43_2

@MooseZM
Copy link
Author

MooseZM commented Jul 20, 2024

Thanks, that worked for the tabs and since i'm using a pure black theme it's not that big of deal. However the issue is still there for the control buttons. Is there any fix for that? Thanks again

@soulhotel
Copy link
Owner

No, to add the window controls to the one-line navigation bar, they had to become fixed buttons, I tried to simulate the same look of the toolbar buttons next to them so that they can blend in properly while keeping consistency between operating systems.

If you want them at the far edge of the window, like Windows 10 style, you can edit the positioning in return-window-controls.css. It would require changing the border radius to 0 to make them square, then moving the 'right' position from 2 to 0, you could even make the 'top' position 0 and make the padding how you want, to change the size of the button.

/* to return the title bar buttons */
:root[tabsintitlebar] .titlebar-buttonbox{
position: fixed !important;
display: flex !important;
z-index: 2 !important;
top: 4.2px !important;
right: 2px !important;
/* left instead of right, if you want it on left side */
}
/* adjust nav bar margin for fixed button */
#nav-bar {
margin-right: 96px;
} /* margin-left if you have it on left side*/
/* 30px total button size to match toolbar buttons. */
@media (-moz-platform: windows) {
.titlebar-buttonbox .titlebar-button {
padding: 11px 11px !important;
}
}

I won't do it because it would look unnatural both for the theme and Windows 11, but it can be done right here.

@MooseZM
Copy link
Author

MooseZM commented Jul 20, 2024

thank you so much, worked like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants