Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Google search tools do not get displayed correctly #123

Closed
DarkPointer opened this issue Aug 1, 2024 · 7 comments
Closed

The Google search tools do not get displayed correctly #123

DarkPointer opened this issue Aug 1, 2024 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DarkPointer
Copy link

Already looked at the Wiki? - https://github.com/soulhotel/FF-ULTIMA/wiki

Yes

Describe the issue:

The Google search tools do not get displayed/rendered correctly after installing the theme

Expected behavior:

The Google search tools do not get affected by the theme

Platform/Desktop:

  • OS: Windows 10
  • Browser Version: Firefox 128.0.3

Video:

Issue.mp4
@soulhotel
Copy link
Owner

soulhotel commented Aug 1, 2024

There are no google web pages touched by the theme. Only youtube, reddit, about:newtab, and about:config. There are also no user preferences that interfere with webpage behavior or appearance as well.

See if the tools appear in a private window - if the issue is gone, then you may have something else going on here.

2024-08-01_11-43

Windows

2024-08-01_11-56

@DarkPointer
Copy link
Author

DarkPointer commented Aug 1, 2024

The issue was successfully reproduced on two different Windows 10 machines with the same Firefox version provided above, one with a fresh Windows and Firefox install, with nothing except the FF-ULTIMA theme installed (Shown in the video above).
The issue was consistent across both normal and private windows.
I could spin up a fresh install of Windows 10 and Firefox on a virtual machine and provide a new video if needed!

@DarkPointer
Copy link
Author

The issue reproduced on a fresh Windows 10 and Firefox install:

IssueVM.mp4

@soulhotel
Copy link
Owner

soulhotel commented Aug 1, 2024

Thats really strange.. as I said before, nothing in the theme touches google webpages, it would require a media query for google domains to even reach that point.

But once i get home ill look into it further. Best case scenario is that I find one of the z-site files to be targetting more than what they should.. Ill update you later on today.

@soulhotel
Copy link
Owner

soulhotel commented Aug 2, 2024

I was able to reproduce the issue as well. It's right here:

/* all scrollbars */
* {
scrollbar-width: auto !important;
scrollbar-color: rgba(170, 170, 170, 0.4) rgba(255,255,255, 0) !important;
}

Apparently the 'Tools' menubar renders as a scrollbar.... but only on Windows 10. The bug doesn't effect Windows 11 or other OS's.

You can open z-site-styles.css and change * to body or :root (better alternative) and the bug will be gone. Or you can download this updated file and replace your original in the chrome/theme folder:

https://github.com/soulhotel/FF-ULTIMA/blob/next-release/theme/z-site-styles.css

/* all scrollbars */
:root {
scrollbar-width: auto !important;
scrollbar-color: rgba(170, 170, 170, 0.4) rgba(255,255,255, 0) !important;
}

@soulhotel soulhotel added bug Something isn't working good first issue Good for newcomers labels Aug 2, 2024
@DarkPointer
Copy link
Author

I appreciate the quick response and can confirm that the issue was resolved after changing * to :root in z-site-styles.css

@soulhotel
Copy link
Owner

Great! Thanks for pointing the issue out too.

@soulhotel soulhotel mentioned this issue Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants