Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Colors need adjustment - for when using an Add-On Theme #182

Closed
dreadbalaur opened this issue Nov 19, 2024 · 2 comments · Fixed by #188
Closed

[Enhancement] Colors need adjustment - for when using an Add-On Theme #182

dreadbalaur opened this issue Nov 19, 2024 · 2 comments · Fixed by #188
Labels
enhancement New feature or request wip Work in progress. No time table set.

Comments

@dreadbalaur
Copy link

dreadbalaur commented Nov 19, 2024

Already looked at the Wiki? - https://github.com/soulhotel/FF-ULTIMA/wiki

Yes

Describe the issue:

Firefox's Alpenglow is a unique beast: it is a native theme that follows the system theme, but even in its light mode there are some dark elements in the UI, namely the burger menu and the address bar.

I don't know how Firefox managed Alpenglow's coding to achieve that in the first place, but all Ultima themes force a light color change to the menu, effectively making the menu illegible in Alpenglow light mode. Default theme makes it transparent, dusky makes it white, and gruvbox light makes it orange.

Expected behavior:

Ideally a way for these dark-UI elements to come back when using Alpenglow?

Platform/Desktop:

  • OS: Windows 10
  • Browser Version: Firefox 124

Picture | Video:
With Ultima Dusky
image
Without Ultima
image

@soulhotel
Copy link
Owner

2024-11-19.21-54-29.mp4

I see what you mean, I haven't looked into it yet but it's definitely because of the freedom that themes have to use color variables however they wish, chaos.

I'll rewrite global-theming (for when addon themes are in use) and override those variables, easy solution, tomorrow night though. When I do make these updates it'll be in the next releases source + changelog, since this release is still 10 days away. Hopefully this will become a one-for-all solution. Until then.

@soulhotel soulhotel added wip Work in progress. No time table set. enhancement New feature or request labels Nov 20, 2024
@soulhotel soulhotel changed the title [Enhancement] Make Alpenglow theme compatible with Ultima? [Enhancement] Colors need adjustment - for when using an Add-On Theme Nov 20, 2024
@soulhotel
Copy link
Owner

2024-11-22.01-23-30.mp4

change log,
update-branch was just updated,
pre-release for FF Ultima 1.9.3 most likely tomorrow.

@soulhotel soulhotel mentioned this issue Nov 22, 2024
@soulhotel soulhotel linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in progress. No time table set.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants