Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar cuts text off #186

Closed
thedolphinisdead opened this issue Nov 21, 2024 · 18 comments · Fixed by #188
Closed

sidebar cuts text off #186

thedolphinisdead opened this issue Nov 21, 2024 · 18 comments · Fixed by #188
Labels
update theme User needs to update FF Ultima to latest version

Comments

@thedolphinisdead
Copy link

Already looked at the Wiki? - https://github.com/soulhotel/FF-ULTIMA/wiki

yes

Describe the issue:

It feels like there are two vertical tab bars, and the "New Tab" is cut off by the second one.

Expected behavior:
I didn't think there were two bars, and it doesn't seem like there's supposed to be based on the videos I've watched.

Platform/Desktop:

  • OS: Windows 11
  • Browser Version: Firefox 133.04

Picture | Video:

image

@soulhotel
Copy link
Owner

Which version of the theme did you download, was it the 1.9.1 zip or the 1.9.1-nightdev.

@soulhotel
Copy link
Owner

Also I have a feeling this is related to Firefox's dark theme just double check that you have it off, and are using the System dark/light auto:

image

@thedolphinisdead
Copy link
Author

tysm, this fixed the second bar, but the start of the "N" from "New tab" is still being cut off

@soulhotel soulhotel linked a pull request Nov 22, 2024 that will close this issue
@soulhotel
Copy link
Owner

The text cut off is probably due to some change in the Sidebar somewhere inside of the 133 updates. Updating to the 1.9.3 release should fix.

@thedolphinisdead
Copy link
Author

tysm, was really bothering me lol

@thedolphinisdead
Copy link
Author

now its doing the same thing but with the buttons at the bottom;
image

@thedolphinisdead
Copy link
Author

oddly it goes normal when i click the sidebar button, but then it doesnt expand when i hover my mouse over it.
image

@soulhotel
Copy link
Owner

which firefox edition are you using?

@soulhotel
Copy link
Owner

If you can just snap a pic of your about page

image

@thedolphinisdead
Copy link
Author

could be because of nightly but it was working a couple hours ago, and there was no update:
image

@soulhotel
Copy link
Owner

Confirmed it's Nightly, because the vertical tab toolbar is different on developer edition (which is really strange).

2024-11-24.00-21-53.mp4

I'm hoping that on November 29th, all of the firefoxs follow this format for the VT toolbar that I have on developer edition because theyve definitely made adjustments to it between version patches. And through observation the adjustments made with the most attention to detail tend to be the final outcome. If not, then I'll just have to fix.

@thedolphinisdead
Copy link
Author

disabling private browsing mode fixed it (partly) but the icons on the bottom are always horizontal unless i press the vertical tabs button in the top left;
image
image

@soulhotel
Copy link
Owner

Since Firefox 133 just dropped I went ahead and made a more official update.

FF Ultima 1.9.3 is officially released with this issue (VT toolbar button spacing) corrected. As well as for Nightly.

2024-11-26.22-10-41.mp4

@soulhotel soulhotel added update theme User needs to update FF Ultima to latest version and removed revisit labels Nov 27, 2024
@Kfkcome
Copy link

Kfkcome commented Nov 27, 2024

Since Firefox 133 just dropped I went ahead and made a more official update.

FF Ultima 1.9.3 is officially released with this issue (VT toolbar button spacing) corrected. As well as for Nightly.
2024-11-26.22-10-41.mp4

Sir, I still got this issue when I use the new version of FF-ULTIMA and stable firefox.

QQ_1732684530993

QQ_1732684645061

@soulhotel
Copy link
Owner

@Kfkcome wow.. What is going on here...

So on Mac, you have the horizontal toolbar buttons like me (on Windows/Linux Developer Edition). But Everywhere else on Default Firefox has vertical toolbar buttons.

@soulhotel
Copy link
Owner

I'm guessing the Firefox developers are handling this differently not only for browser versions but OS's, so this makes it a bit annoying but, I updated the release with a patch that targets Mac only (3+ pixels for the toolbar buttons to the right).

https://github.com/soulhotel/FF-ULTIMA/releases/tag/1.9.3

@Kfkcome
Copy link

Kfkcome commented Nov 27, 2024

I'm guessing the Firefox developers are handling this differently not only for browser versions but OS's, so this makes it a bit annoying but, I updated the release with a patch that targets Mac only (3+ pixels for the toolbar buttons to the right).

https://github.com/soulhotel/FF-ULTIMA/releases/tag/1.9.3

Thanks!! It work fine now.

@soulhotel
Copy link
Owner

@Kfkcome Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update theme User needs to update FF Ultima to latest version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants