Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable.verticaltab.bar not working #193

Closed
tbeest opened this issue Nov 26, 2024 · 5 comments
Closed

Disable.verticaltab.bar not working #193

tbeest opened this issue Nov 26, 2024 · 5 comments
Labels
update theme User needs to update FF Ultima to latest version

Comments

@tbeest
Copy link

tbeest commented Nov 26, 2024

Already looked at the Wiki? - https://github.com/soulhotel/FF-ULTIMA/wiki

yes

Describe the issue:

Despite putting "ultima.disable.verticaltab.bar" to yes it does not hide the vertical tab bar like shown in the wiki, bot when "expand sidebar" is toggled on or off.

Expected behavior:

I'd expect the vertical tab bar to be hidden, as I wish to replace it with Sideberry.

Platform/Desktop:

  • OS: Windows 11
  • Browser Version: Firefox 132.0.2
  • FF-ULTIMA 1.9.1

Picture | Video:

image
image

@soulhotel
Copy link
Owner

Firefox Default should be on 133 now, update Firefox then get the FF Ultima 1.9.3 release.

@soulhotel soulhotel added the update theme User needs to update FF Ultima to latest version label Nov 27, 2024
@tbeest
Copy link
Author

tbeest commented Nov 27, 2024

That was some timing. I have updated both browser and theme and it seems mostly fixed now, though it does leave this little blue tab in the bottom left corner;
image image

Hovering over that pops out the (default? Ultima?) sidebar. Ideally I'd hide that too.

@soulhotel
Copy link
Owner

@tbeest

I thought it would be convenient to have the sidebar still accessible just in case someone still wants to be able to access it. Maybe they have the sidebery button there and not on the nav bar, or maybe they want to switch the sidebar to history or bookmarks sidebar then back to sidebery.

Since this is still a new idea, there are options for where I can take it. I can either make another setting that completely hides the VT. Or I can change the look and location of this little tab to be less instrusive. I would like some recommendations on how it should look though.

@soulhotel
Copy link
Owner

Alright I settled on a style for it, by default it will hide the vertical tab bar completely, with a setting right below it to include the tab for if a User wants that.

2024-11-27.22-47-19.mp4

Will most likely drop a 1.9.5 release tomorrow with this included.

@tbeest
Copy link
Author

tbeest commented Nov 28, 2024

Thank you so much!

I'll be looking forward to the release.

@tbeest tbeest closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update theme User needs to update FF Ultima to latest version
Projects
None yet
Development

No branches or pull requests

2 participants