Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window_type not applied in signal.rstft() and signal.spectrogram() #8

Open
LasseBoerresen opened this issue Oct 22, 2015 · 0 comments

Comments

@LasseBoerresen
Copy link

I noticed a bug in signal.rstft(). It does not store the output of apply_window(window, window_type), line 396.

solution is:
line 396: window = apply_window(window, window_type)

Additionally, there is no option on function signal.spectrogram to chose window_type, consequently the default window_type of rstft, 'rect', is used, which gives bad effects on the spectrogram image because of edge effects. Please add the option.

best regards
L. S. Børresen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant