Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Fix sphere not showing #2

Closed
soumyasen1809 opened this issue Aug 9, 2024 · 0 comments
Closed

[5.1] Fix sphere not showing #2

soumyasen1809 opened this issue Aug 9, 2024 · 0 comments
Assignees
@soumyasen1809
Labels
bug Something isn't working

Comments

@soumyasen1809
Copy link
Owner

Check
fn is_sphere_hit(center: &Point3, radius: f64, ray: &Ray) -> bool
not showing the sphere in the generated ppm

Check https://github.com/ebkalderon/ray-tracing-in-one-weekend/commits/master/
@soumyasen1809 soumyasen1809 added the bug Something isn't working label Aug 9, 2024
@soumyasen1809 soumyasen1809 self-assigned this Aug 9, 2024
soumyasen1809 added a commit that referenced this issue Aug 9, 2024
@soumyasen1809
[none] Fixes issue where sphere not showing
e8a7765 
- Fixed issue where red sphere not showing in the
ppm image.
- Error in calculating the location of upper left pixel

%SOFTWARE
Fixes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soumyasen1809 soumyasen1809

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soumyasen1809