Added scene with Lambertian and Metal materials #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
soumyasen1809
commented
Aug 14, 2024
soumyasen1809
commented
- Fixed issue PPM generated is completely black #6
- Added Metal and Lambertian materials
- Added trait for Materials
- Added utility functions to generate random vectors. This will simulate the random light rays bouncing off the sphere. - Determine if ray is on the correct hemisphere by comparing against the surface normal - Limiting number of child rays. The ray_color function is recursive. When will it stop recursing? When it fails to hit anything. In some cases, however, that may be a long time — long enough to blow the stack. To guard against that, limited the maximum recursion depth, returning no light contribution at the maximum depth. %SOFTWARE
- Ignore points close to the calculated intersection point. - Uses interval min as 0.01 instead of 0.0 %SOFTWARE
We want to select the tangent unit sphere that is on the same side of the surface as the ray origin. Pick a random point S point P on this unit radius sphere and send a ray from the hit to the random point S - Added random unit vector to the sphere ray color %SOFTWARE
It is likely that the image viewer you are using is expecting an image in gamma space, but we are giving it an image in linear space. This is the reason why our image appears inaccurately dark. Hence we use Gamma correction for accurate color intensity. - Added linear space to gamma space correction (Gamma 2) %SOFTWARE
% SOFTWARE
- Issue in color of the spheres %SOFTWARE
- Bug No change in pic generated %SOFTWARE
- Removed extra HittableObject %SOFTWARE
- Added metal spheres to the scene - Pass world as a Vec<Box<dyn Hittable>> to Camera %SOFTWARE Fixes Issue #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.