Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetBrains, IntelliJ, Java renderer] @ sign breaks in javadoc tags like {@link hello} in IntelliJ IDEA #42

Closed
jevring opened this issue Aug 31, 2015 · 12 comments

Comments

@jevring
Copy link

jevring commented Aug 31, 2015

The @ sign by itself works fine, and in any code and string literals, it works fine. This could be an issue with IntelliJ IDEA, but it seems to work fine for other fonts. I have included a sample image.
hack_font_javadoc_failure

@jdhoek
Copy link

jdhoek commented Aug 31, 2015

I have just installed Hack, but I cannot reproduce this in IntelliJ IDEA (Ubuntu Linux 15.04); {@link hello} works as expected.

Perhaps you could add some details such as your operating system?

@jevring
Copy link
Author

jevring commented Aug 31, 2015

Sure, I'm using Windows 7, IDEA 14.1.4.
It's anything defined as a @tag, so things like @author and any custom tags also get this behavior. In my style, which is the default, these tags are underlined. It could be that @ with an underline changes to this other character seen in the image.

@aGustafsson
Copy link

I have the same issue (Windows 8.1, PhpStorm 9.0.2). Happens for bold oblique @ character.

@chrissimpkins
Copy link
Member

Checking the JetBrains issue reporting forums for similar reports. This is the third rendering issue that has been reported so far in JetBrains editors. It's not clear to me where the problem lies. I will post new issue reports there if I don't come up with any existing information.

Updates to follow.

@eXtreme
Copy link

eXtreme commented Aug 31, 2015

Having the same problem, Windows 10, IntelliJ IDEA 14.1.4, TTF hack font.

Even more bizzare stuff happens when I installed OTF version:

image

Just to add my observation, I have "show whitespace" option enabled (means spaces are represented with barely visible dots - not in the case above :)).

@chrissimpkins
Copy link
Member

@jevring here is the same block with the ttf files in WebStorm on OS X (10.10.5) that (to my knowledge) uses the same Java renderer as IntelliJ:

webstormimage

On OS X the JetBrains editors render their own oblique for many (but apparently not all) fonts with too much slant. This is a known issue on the OS X platform and they have received reports about it.

Your issue seems to be Windows specific based upon your report and the one by @eXtreme. I've confirmed that the same text block renders with only the large slant issues in PyCharm on OS X as well.

@chrissimpkins
Copy link
Member

@eXtreme Do you mind adding the actual text that you used in that screenshot as a codeblock? I'd like to see what glyphs are involved.

@eXtreme
Copy link

eXtreme commented Aug 31, 2015

@chrissimpkins well it is nothing out of ordinary:

/**
 */
class ApplicationController implements ClassResourceInterface
{
    /** @var EventDispatcherInterface */
    protected $eventDispatcher;
    /** @var ApplicationManager */
    protected $applicationManager;
    /** @var CommandBus */
    protected $commandBus;
    /** @var RouterInterface */
    protected $router;

    public function __construct(
        EventDispatcherInterface $eventDispatcher,
        ApplicationManager $applicationManager,
        CommandBus $commandBus,
        RouterInterface $router
    )
    {
        $this->eventDispatcher = $eventDispatcher;
        $this->applicationManager = $applicationManager;
        $this->commandBus = $commandBus;
        $this->router = $router;
    }

it's just spaces.

And this is how it looks with "Consolas" font:

image

you can see these little dots where spaces are. I have no idea what glpyhs Idea uses for these dots.

@chrissimpkins chrissimpkins changed the title @ sign breaks in javadoc tags like {@link hello} in IntelliJ IDEA [JetBrains, IntelliJ, Java renderer] @ sign breaks in javadoc tags like {@link hello} in IntelliJ IDEA Sep 2, 2015
@chrissimpkins
Copy link
Member

Will you please give these new builds a try (v2.012)? I've updated the name tables and adjusted the font names based upon what is currently recommended for cross-platform support. Let's see if this addresses this issue.

Download Links
Regular
Bold
Italic
BoldItalic

@jevring
Copy link
Author

jevring commented Sep 5, 2015

Now everything looks good. Thanks! =)

@jevring jevring closed this as completed Sep 5, 2015
@chrissimpkins
Copy link
Member

excellent!

@chrissimpkins
Copy link
Member

Thanks for the issue report and for your testing to implement this fix. It is now live in release v2.013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants