Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #338

Merged
merged 1 commit into from
May 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/test_servo_board.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def test_servo_board_identify(servoboard_serial: MockServoBoard) -> None:
assert servo_board.identify().asset_tag == "TEST456"


@pytest.mark.skip(reason="TODO update servo values")
def test_servo_board(servoboard_serial: MockServoBoard) -> None:
"""
Test that the servo board functionality works.
Expand Down Expand Up @@ -97,7 +96,6 @@ def test_servo_board(servoboard_serial: MockServoBoard) -> None:
assert servo_board.voltage == 5.432


@pytest.mark.skip(reason="TODO update servo values")
def test_servo_board_servos(servoboard_serial: MockServoBoard) -> None:
"""
Test that the servo board servo functionality works.
Expand All @@ -119,6 +117,7 @@ def test_servo_board_servos(servoboard_serial: MockServoBoard) -> None:
])
# Test that we can set the duty cycle limits
servo_board.servos[0].set_duty_limits(1000, 1100)
servo_board.servos[1].set_duty_limits(1000, 2000)

# Test that we can get the duty cycle limits
assert servo_board.servos[0].get_duty_limits() == (1000, 1100)
Expand Down
Loading