Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): extra login asked when going into cicd and pull requests tabs #137

Merged
merged 2 commits into from
May 6, 2024

Conversation

sadarunnisa-sf
Copy link
Contributor

@sadarunnisa-sf sadarunnisa-sf commented Apr 19, 2024

Extra login asked when asked when going into cicd and pull requests tabs

Same type of issue as -> ARC-117

Description

After logging in, when we open service and go to CICD tab, it is again asking for login. Even though this is happening first time only but its not something which is expected.
image
image

  • This is the issue with plugin @backstage/plugin-github-actions package.
  • We have used this package fetching, listing workflows. For access token, they have used scope as 'repo'.
  • On the other hand we use scope 'read:user' for access token.
  • Instead of adding 'repo' scope for github login( which gives read/write/commit etc repo access to token), changed scope in the plugin npm package to 'read:user'. (https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/scopes-for-oauth-apps)
  • As this change is from '@backstage/plugin-github-actions' package, used patch-package for the same (https://www.npmjs.com/package/patch-package). Created patch which run on postinstall.
    Updated result:
    image
    image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

extra login asked when going into cicd tab from component

ARC-117
@sadarunnisa-sf sadarunnisa-sf changed the title fix(plugins): extra login asked when going into cicd tab from component fix(plugins): extra login asked when going into cicd tab Apr 19, 2024
@sadarunnisa-sf sadarunnisa-sf removed the request for review from jamescrowley321 April 19, 2024 14:19
…tabs

extra login asked when going to cicd and pull requests tabs

ARC-117
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sadarunnisa-sf sadarunnisa-sf changed the title fix(plugins): extra login asked when going into cicd tab fix(plugins): extra login asked when going into cicd and pull requests tabs Apr 19, 2024
@sadarunnisa-sf sadarunnisa-sf removed the request for review from jamescrowley321 April 22, 2024 11:14
@jamescrowley321
Copy link
Contributor

LGTM and tested please @sadarunnisa-sf

@sadarunnisa-sf sadarunnisa-sf requested review from jamescrowley321 and removed request for jamescrowley321 April 22, 2024 14:51
@sadarunnisa-sf sadarunnisa-sf merged commit e08187d into main May 6, 2024
5 checks passed
@sadarunnisa-sf sadarunnisa-sf deleted the ARC-117-cicd-tab-issue branch May 6, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants