Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Struct fields are rendered without comments in hover #175

Open
zmb3 opened this issue Mar 9, 2017 · 2 comments
Open

Struct fields are rendered without comments in hover #175

zmb3 opened this issue Mar 9, 2017 · 2 comments

Comments

@zmb3
Copy link

zmb3 commented Mar 9, 2017

Before enabling language server in VS Code, the hover tooltip would show comments on fields. (Note the // identifies the driver comment I added for illustration.

ggd-struct-comment

When language server is enabled, this information is no longer present.

ls-struct-comment

Similarly, it was possible to hover over a field and get the doc/comment for that field:
ggd-struct-field

But with language server there is no doc:
ls-struct-field

@keegancsmith
Copy link
Member

There was some debate about what to include in the hover tooltip here #169 which you are welcome to add too. This is different than before, but not convinced it is valuable to add back in.

Missing the docs on hovering a struct field sounds like a regression. I'll fix + update the test suite to prevent that from regressing again.

@slimsag
Copy link
Member

slimsag commented Jun 29, 2017

FYI this no longer happens when using the language server with VS Code since the new godef-based hover implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants