feat(typescript): upgrade to typescript 2.8.3 (#452)

sourcegraph · May 8, 2018 · 15579a1 · 15579a1
1 parent 35b0140
commit 15579a1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,7 +51,7 @@
     "rxjs": "^5.5.0",
     "semaphore-async-await": "^1.5.1",
     "string-similarity": "^1.1.0",
-    "typescript": "2.7.2",
+    "typescript": "2.8.3",
     "vscode-jsonrpc": "^3.3.1",
     "vscode-languageserver": "^3.1.0",
     "vscode-languageserver-types": "^3.0.3"

diff --git a/src/diagnostics.ts b/src/diagnostics.ts
@@ -35,6 +35,7 @@ function convertDiagnosticCategory(category: ts.DiagnosticCategory): DiagnosticS
             return DiagnosticSeverity.Warning
         case ts.DiagnosticCategory.Message:
             return DiagnosticSeverity.Information
-        // unmapped: DiagnosticSeverity.Hint
+        case ts.DiagnosticCategory.Suggestion:
+            return DiagnosticSeverity.Hint
     }
 }
diff --git a/src/test/typescript-service-helpers.ts b/src/test/typescript-service-helpers.ts
@@ -2297,11 +2297,11 @@ export function describeTypeScriptService(
                             uri: 'git://github.com/Microsoft/TypeScript?v' + ts.version + '#lib/lib.dom.d.ts',
                             range: {
                                 start: {
-                                    line: 8446,
+                                    line: 9378,
                                     character: 10,
                                 },
                                 end: {
-                                    line: 8446,
+                                    line: 9378,
                                     character: 14,
                                 },
                             },
@@ -2310,11 +2310,11 @@ export function describeTypeScriptService(
                             uri: 'git://github.com/Microsoft/TypeScript?v' + ts.version + '#lib/lib.dom.d.ts',
                             range: {
                                 start: {
-                                    line: 8498,
+                                    line: 9429,
                                     character: 12,
                                 },
                                 end: {
-                                    line: 8498,
+                                    line: 9429,
                                     character: 16,
                                 },
                             },
@@ -3309,8 +3309,8 @@ export function describeTypeScriptService(
                             fileName: toUnixPath(uri2path(rootUri + 'a.ts')), // path only used by TS service
                             textChanges: [
                                 {
-                                    span: { start: 49, length: 13 },
-                                    newText: '\t\tthis.missingThis',
+                                    span: { start: 51, length: 11 },
+                                    newText: 'this.missingThis',
                                 },
                             ],
                         },