-
Notifications
You must be signed in to change notification settings - Fork 72
feat: Add goto type definition. #475
feat: Add goto type definition. #475
Conversation
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 83.08% 83.08% +<.01%
==========================================
Files 15 15
Lines 2046 2052 +6
Branches 416 420 +4
==========================================
+ Hits 1700 1705 +5
- Misses 344 345 +1
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
You also need to announce the capability in the InitializeResult.
src/typescript-service.ts
Outdated
} | ||
}) | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a lot of this implementation is copy-pasted except one line, would it maybe be possible to share to most the code?
Not sure what I need to do for this. EDIT: Actually I think I know what you mean, but it looks like it is covered by |
I added the capability |
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds support to go directly to the type definition for the symbol under the cursor.