New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBT version comparison is not working correctly #709

Closed

keynmol opened this issue May 20, 2024 · 0 comments · Fixed by #710

Labels

graph/scip-java team/graph

Contributor

keynmol commented May 20, 2024

The message should explain it all:

error: Unsupported sbt version '1.10.0'. To fix this problem, upgrade to sbt 1.9.7 and try again.

The comparison logic doesn't order versions correctly: https://github.com/sourcegraph/scip-java/blob/main/scip-java/src/main/scala/com/sourcegraph/scip_java/buildtools/SbtBuildTool.scala#L65-L68

github-actions bot added graph/scip-java team/graph labels

keynmol mentioned this issue

Fix and refactor SBT version logic #710

Merged

keynmol closed this as completed in #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment