Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR review bot: Possible to disable "overall comments" and line-level suggestions? #439

Closed
3 tasks done
blakeNaccarato opened this issue Oct 8, 2024 · 2 comments
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@blakeNaccarato
Copy link

Checklist

  • This is a new feature, not a refactoring suggestion
  • I have checked for this feature in the Sourcery documentation
  • I have checked there are no open requests referencing the same feature

Description

I like the PR summarizing/digest features of the AI review bot, and think it could be helpful as a "rough draft" review summary. However, I would really like to disable the line-level scrutiny, comments, and improvement suggestions of the review bot.

Regardless of the quality or tone of these suggestions, I'd like to have a policy in my projects that the quality of PRs submitted by others isn't directly assessed by the bot, which I think can be a bit impersonal and off-putting. Besides, any invalid/excessive suggestions may generate churn and unnecessary commits in an attempt to "appease" our robot overlords 😅 before a human reviewer gets around to it.

I tried passing the following to the "instructions" dashboard section, but review comments were still made. I left the path glob empty so maybe that needs to be **/* or * or something, or those instructions do not affect the actual comment mechanism itself.

- Please do not make any comments.
- Please do not give any suggestions for improvement.

Anyways, I appreciate that the other toggles are present, and I imagine the review comments are the "first line

@blakeNaccarato blakeNaccarato added the enhancement New feature or request label Oct 8, 2024
@ruancomelli
Copy link
Contributor

Hello, @blakeNaccarato!

Currently, our review instructions can only be used to generate additional review comments, not to suppress comments that it already generates by default. That's in our roadmap, but it's not available yet.

However, we now have an option to completely disable AI review comments. Please head over to your Sourcery dashboard and un-toggle the "Enable AI review comments" option:

Image

@ruancomelli ruancomelli self-assigned this Nov 11, 2024
@blakeNaccarato
Copy link
Author

Ah, alright I see that toggle now. Must've escaped me when I first raised the issue. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants