Refactoring causing RecursionError

[MarcoGorelli]

Hi,

I tried using Sourcery to refactor some of the pandas code, and it suggested a refactoring which caused a RecursionError:

-        for i in range(len(self)):
-            yield self[i]
+        yield from self

See pandas-dev/pandas#37581

Flagging this up in case it's useful to you

[Hellebore]

Thanks for raising! We'll take a look.

[MarcoGorelli]

No worries! here's another refactoring which didn't work for us

[Hellebore]

No worries! here's another refactoring which didn't work for us

That's an interesting one - we rely on the typing to infer that it's a list so we can do that refactoring.

[MarcoGorelli]

Ah OK, so in that one the refactoring brought up an incorrect type annotation...thanks!

[brendanator]

Thanks for the report. Fix identified and will be in the next release

[Hellebore]

Resolved with release of 0.8.3