Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect: Test cases use pre-F2018 co_reduce()-parameter operator, which is renamed in F2018 to operation #745

Closed
1 task done
vehre opened this issue Jan 10, 2022 · 5 comments

Comments

@vehre
Copy link
Collaborator

vehre commented Jan 10, 2022

In gcc>=12 the Fortran Standard 2018's co_reduce(... operation=...) is implement. Code using pre-2018 Fortran (and still using operator=...) will stop compiling.

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information.

  • I am reporting a bug others will be able to reproduce and not asking a question or requesting a new feature.

System information including:

  • OpenCoarrays Version:
  • Fortran Compiler:
  • C compiler used for building lib:
  • Installation method:
  • All flags & options passed to the installer
  • Output of uname -a:
  • MPI library being used:
  • Machine architecture and number of physical cores:
  • Version of CMake:

To help us debug your issue please explain:

What you were trying to do (and why)

What happened (include command output, screenshots, logs, etc.)

What you expected to happen

Step-by-step reproduction instructions to reproduce the error/bug

Compile testsuite with gcc>=12.

@vehre
Copy link
Collaborator Author

vehre commented Jan 10, 2022

Fix is available at: https://github.com/sourceryinstitute/OpenCoarrays/tree/issue-745-rename-co_reduce-operator-for-F2018

The fix uses the pre-processor to use the different identifiers depending on the gcc-version used. Therefore the files had to renamed to *.F90, i.e. with a capital F which by convention enables preprocessor-processing.

GitHub
A parallel application binary interface for Fortran 2018 compilers. - GitHub - sourceryinstitute/OpenCoarrays at issue-745-rename-co_reduce-operator-for-F2018

@rouson
Copy link
Member

rouson commented Jan 10, 2022

Thanks, @vehre! Please open a pull request to merge this fix into the main branch.

@everythingfunctional please let me know if you can review and merge the PR

@everythingfunctional
Copy link
Collaborator

Sounds straightforward enough. Open a PR and I'll review it.

@vehre
Copy link
Collaborator Author

vehre commented Jan 11, 2022

The pull reQuest is at: #746

@rouson
Copy link
Member

rouson commented Feb 18, 2022

PR #746 has been merged so I'm closing this issue.

@rouson rouson closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants