Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noticeable pause when sourmash tries to load a ZipFile collection as an SBT #1506

Closed
ctb opened this issue May 8, 2021 · 2 comments
Closed

noticeable pause when sourmash tries to load a ZipFile collection as an SBT #1506

ctb opened this issue May 8, 2021 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented May 8, 2021

There's a noticeable pause while _load_sbt in _load_database tries to load a .zip file as an SBT (before failing and going on to load it as a .zip file, correctly). Not sure what's going on here.

Punted here as a remaining issue from #1483
@ctb ctb mentioned this issue May 8, 2021
Closed
@ctb
Copy link
Contributor Author

ctb commented Jun 26, 2021

maybe related to big memory peak on SBT loading #1197

@ctb
Copy link
Contributor Author

ctb commented Aug 3, 2022 •
edited
Loading

looks like this was fixed by #1909, which oxidized ZipStorage!

@ctb ctb closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb