Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer more SaveSignatures functionality over to the Index class? #1953

Open
ctb opened this issue Apr 15, 2022 · 0 comments
Open

transfer more SaveSignatures functionality over to the Index class? #1953

ctb opened this issue Apr 15, 2022 · 0 comments

Comments

@ctb
Copy link
Contributor

ctb commented Apr 15, 2022

I've shied away from implementing insert and/or save generically on Index classes, but it'd be useful to have (and, per #1936, have it be tested in a standard way). As it is in scripts we tend to use sourmash_args.SaveSignaturesToLocation(...) which has a fairly complete parallel implementation of signature saving logic. It'd be nice to switch this code over to just managing insertion and commit of the appropriate on-disk storage, with all the other logic moved into the Index class as possible.

this is a more general version of #1756...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant