Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hypothesis tests are now failing? #2026

Closed
ctb opened this issue May 3, 2022 · 7 comments · Fixed by #2028
Closed

hypothesis tests are now failing? #2026

ctb opened this issue May 3, 2022 · 7 comments · Fixed by #2028

Comments

@ctb
Copy link
Contributor

ctb commented May 3, 2022

with this error:

...
iff_cover.command_runner.CommandError: fatal: ambiguous argument 'origin/latest...HEAD': unknown revision or path not in the working tree.

which seems very weird to just suddenly happen. I don't think we recently updated anything that would cause this to break, but hypothesis is not in fact version pinned in setup.cfg so maybe it's being caused by a new version?

@ctb
Copy link
Contributor Author

ctb commented May 3, 2022

https://pypi.org/project/hypothesis/6.46.2/ just got released. maybe that's causing problems.

@mr-eyes
Copy link
Member

mr-eyes commented May 3, 2022

@ctb
Copy link
Contributor Author

ctb commented May 3, 2022

yeah... but that shouldn't have been a thing that suddenly changed! 🤔

@mr-eyes
Copy link
Member

mr-eyes commented May 3, 2022

I have just tested it locally and it worked just fine. Can you try restarting the workflow?

@mr-eyes
Copy link
Member

mr-eyes commented May 3, 2022

I restarted the workflow, and the problem is still there.
Originated from this line

diff-cover --compare-branch {env:DIFF_AGAINST:origin/latest} {toxworkdir}/coverage.xml

@ctb
Copy link
Contributor Author

ctb commented May 3, 2022

(it's broken on multiple PRs)

@luizirber
Copy link
Member

luizirber commented May 4, 2022

I think it was #2018, probably checkout@3 doesn't pick latest and the actual PR branch. Note that the ASV check already has a similar config (because it needs both the PR and latest available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants