Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider supporting empty picklists in the picklist API #2096

Closed
ctb opened this issue Jun 23, 2022 · 0 comments · Fixed by #2106
Closed

consider supporting empty picklists in the picklist API #2096

ctb opened this issue Jun 23, 2022 · 0 comments · Fixed by #2106

Comments

@ctb
Copy link
Contributor

ctb commented Jun 23, 2022

in #1924 (released in v4.4.0), we changed picklist loading so that it failed on empty picklist files, among other things. this required some slightly ugly code to be needed in charcoal in dib-lab/charcoal#215, ref in #2094.

It would be simple to add an allow_empty flag on picklist loading. Maybe we should do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] support loading of empty picklists sourmash-bio/sourmash
1 participant
@ctb