Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sourmash requirements for screed >= 1.1 #2394

Closed
ctb opened this issue Dec 4, 2022 · 0 comments · Fixed by #2415
Closed

update sourmash requirements for screed >= 1.1 #2394

ctb opened this issue Dec 4, 2022 · 0 comments · Fixed by #2415

Comments

@ctb
Copy link
Contributor

ctb commented Dec 4, 2022

No description provided.

@ctb ctb mentioned this issue Dec 18, 2022
Merged
@ctb ctb closed this as completed in #2415 Mar 5, 2023
ctb added a commit that referenced this issue Mar 5, 2023
@ctb @luizirber
MRG: update version of screed to >= 1.1,<2 (#2415)
ace25cd 
Fixes #2394.

The main update in screed from 1.0.5 to 1.1 was
dib-lab/screed#90, which closes an unclosed file
handle.

This PR also puts an upper bound on the screed version.

---------

Co-authored-by: Luiz Irber <contact+github@luizirber.org>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: update version of screed to >= 1.1,<2 sourmash-bio/sourmash
1 participant
@ctb