Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBT JSON file should contain ksize and moltype #63

Closed
ctb opened this issue Dec 12, 2016 · 3 comments
Closed

SBT JSON file should contain ksize and moltype #63

ctb opened this issue Dec 12, 2016 · 3 comments
Labels
sbt

Comments

@ctb
Copy link
Contributor

ctb commented Dec 12, 2016

'nuff said. Right now you need to wait until sourmash tries to search one of the leaf nodes to find out if you are searching a tree with the right kind of signature!
@luizirber luizirber added the sbt label Jan 20, 2017
@ctb ctb mentioned this issue May 19, 2017
Closed
@ctb
Copy link
Contributor Author

ctb commented Dec 3, 2017

and num or scaled, too.

@ctb
Copy link
Contributor Author

ctb commented Dec 3, 2017

This is being fixed in #380 by traversing the tree, which could be slow for some storages (e.g. IPFS). It does seem like something that could be stored directly in the index, @luizirber.

@ctb ctb mentioned this issue Jun 13, 2021
Closed
@ctb
Copy link
Contributor Author

ctb commented Jun 25, 2021

this was fixed both in some selector PRs and also now in #1590, which provides (still-optional) manifests that contain this information (and more!)

@ctb ctb closed this as completed Jun 25, 2021
@ctb ctb mentioned this issue Mar 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sbt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luizirber @ctb