Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate 'sourmash lca gather' in sourmash 3.0 #728

Closed
ctb opened this issue Sep 8, 2019 · 1 comment · Fixed by #1031
Closed

Deprecate 'sourmash lca gather' in sourmash 3.0 #728

ctb opened this issue Sep 8, 2019 · 1 comment · Fixed by #1031
Labels
4.0 issues to address for a 4.0 release

Comments

@ctb
Copy link
Contributor

ctb commented Sep 8, 2019

It is now entirely redundant with sourmash gather, or at least it should be ;)
@luizirber luizirber mentioned this issue Sep 8, 2019
Merged
11 tasks
@luizirber Octobox
Copy link
Member

We can add it to the Index ABC PR, there is an example of using the @deprecated decorator in https://github.com/dib-lab/sourmash/pull/556/files#diff-f01fb6a1122709b5d46828f26c23854aR212

@ctb ctb added the 4.0 issues to address for a 4.0 release label May 3, 2020
@ctb ctb mentioned this issue Jun 19, 2020
Merged
5 tasks
@ctb ctb closed this as completed in #1031 Jun 20, 2020
@ctb ctb mentioned this issue Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix lca gather to work on non-DNA databases. sourmash-bio/sourmash
2 participants
@luizirber @ctb