Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current SBT implementation is poorly localized #756

Open
olgabot opened this issue Oct 22, 2019 · 2 comments
Open

Current SBT implementation is poorly localized #756

olgabot opened this issue Oct 22, 2019 · 2 comments

Comments

@olgabot
Copy link
Collaborator

olgabot commented Oct 22, 2019

As mentioned here, the current implementation of SBTs is poorly localized. When building a nearest neighbor graph on the current SBTs, which assumes that leaves sharing parents are more similar than leaves not sharing neighbors, one gets the right side of the nearest neighbor graph, instead of the correct one on the left.

Screen Shot 2019-10-22 at 9 20 58 AM

Thanks @phoenixAja for getting me to finally write up the issue :)

@olgabot
Copy link
Collaborator Author

olgabot commented Oct 22, 2019

This could be rust-y?

@olgabot
Copy link
Collaborator Author

olgabot commented Oct 22, 2019

Could be related to: #545 (allsome/split-sbt implementations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant