-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plans for sourmash 4.0 #835
Comments
Drop Python 2.7 support? |
There are some leftovers in https://github.com/dib-lab/sourmash/projects/2 for sourmash 3.0, should we create another project and track 4.0 (or just use issues/labels, since the projects are not being used anyway? 😬 ) |
We love it, if you guys can improve here are some stats... looks like v3 may be slower than v2? Should we file a task? we are happy to help. perhaps in v4? Is a smaller release planned on top of v3 codebase anytime soon? thanks
|
On Wed, Jan 08, 2020 at 07:40:57AM -0800, Luiz Irber wrote:
There are some leftovers in https://github.com/dib-lab/sourmash/projects/2 for sourmash 3.0, should we create another project and track 4.0 (or just use issues/labels, since the projects are not being used anyway? 😬 )
oh, I'm fine with using projects and can do that for 4.0. but sometimes
discussions are also good :)
|
regarding versions, optimizations and speed, per @satishv comment -- a collection of random thoughts. 3.x should be compatible with 2.x in terms of databases and core functionality, although we may be adding new command line flags. So you can always use 2.x for now! In terms of optimization, my personal perspective (not necessarily shared by others :) is that functionality & correctness, maintainability, user experience, and memory usage come before speed. There are no hard and fast rules here, of course, but we have finite attentional resources and have to prioritize somehow. That having been said, we are always happy to take contributions. The move to rust in 3.0 is opening up a lot of potential optimizations, since rust is (among other things) threadsafe and robust, and we would be happy to receive PRs for specific optimizations. We are also enthusiastic about benchmarking that highlights problem areas, because more information is always better - so thanks, Satish! |
closing, since I think this has mostly been addressed! also see #1016 |
Excerpted from #762, now that 3.0 is out --
thoughts for 4.0 include,
--scaled
the default instead of--num-hashes
(this is controversial tho :)The text was updated successfully, but these errors were encountered: