Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix error when --scaled 1 is set. #156

Merged
merged 11 commits into from
Apr 10, 2017
Merged

[MRG] Fix error when --scaled 1 is set. #156

merged 11 commits into from
Apr 10, 2017

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 9, 2017

Fixes #152 by setting max_hash to be 0 when --scaled=1.

Also addresses #112 by adding MINHASH_MAX_HASH and a getter to the extension module,
and adds a module-level getter for DEFAULT_SEED (#96).

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Apr 9, 2017

Codecov Report

Merging #156 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   85.55%   85.34%   -0.22%     
==========================================
  Files          13       13              
  Lines        1828     1829       +1     
  Branches       52       52              
==========================================
- Hits         1564     1561       -3     
- Misses        255      259       +4     
  Partials        9        9
Impacted Files Coverage Δ
sourmash_lib/commands.py 89.13% <100%> (-0.64%) ⬇️
sourmash_lib/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcedd7...b2e26ee. Read the comment docs.

@ctb ctb changed the title Fix error when --scaled 1 is set. [MRG] Fix error when --scaled 1 is set. Apr 9, 2017
@ctb
Copy link
Contributor Author

ctb commented Apr 9, 2017

Ready for review!

Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctb ctb merged commit 213e9cb into master Apr 10, 2017
@ctb ctb deleted the fix/scaled_1 branch April 10, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants