Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lazy evaluation for key generation #100

Closed
jeffreyyoungs-vgs opened this issue Dec 28, 2016 · 2 comments
Closed

Use lazy evaluation for key generation #100

jeffreyyoungs-vgs opened this issue Dec 28, 2016 · 2 comments
Assignees
Milestone

Comments

@jeffreyyoungs-vgs
Copy link

jeffreyyoungs-vgs commented Dec 28, 2016

You already use unless...

# Use unless instead of not_if otherwise OpenSSL::PKey::DH runs every time.
unless ::File.exist?("#{key_dir}/dh#{key_size}.pem")

But when I wrap the cookbook and have my own key process, this still runs at converge time on the first run unnecessarily. If you use the recommended key size (4096) this is extremely painful.

My workaround was to send a key size smaller than I'm actually using (side-effects unknown), but lazy evaluation should deal with this nicely.

https://docs.chef.io/resource_common.html#lazy-evaluation

@flaccid
Copy link
Contributor

flaccid commented Dec 29, 2016

This one got through in recent commits by stealth. @jeffreyyoungs-vgs please test with master and re-open if any issues.

@flaccid flaccid closed this as completed Dec 29, 2016
@flaccid flaccid self-assigned this Dec 29, 2016
@flaccid flaccid added this to the v3 milestone Dec 29, 2016
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants