Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate chef-rundeck #173

Open
ev0ldave opened this issue Aug 1, 2017 · 8 comments
Open

Deprecate chef-rundeck #173

ev0ldave opened this issue Aug 1, 2017 · 8 comments
Labels
Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Maintenance Maintenance issues such as failing builds Waiting on Contributor Awaiting on the person who raised this to update

Comments

@ev0ldave
Copy link
Contributor

ev0ldave commented Aug 1, 2017

@atheiman
Deprecate chef-rundeck as the project has gone stale and a better constructed project has evolved since then that is more flexible.
Possibly include support for better-chef-rundeck? Would like to discuss moving this into it's own cookbook.

@atheiman
Copy link
Contributor

atheiman commented Aug 1, 2017

i dont think that needs to be its own cookbook. at my office we run better-chef-rundeck using simple-passenger-cookbook. all that is needed is to set a few attrs and include_recipe 'simple_passenger::default'

# attributes.rb
default['passenger']['apps']['better-chef-rundeck'].tap do |bcr|
  bcr['git_repo'] = 'https://github.com/atheiman/better-chef-rundeck.git'
  bcr['git_revision'] = 'v0.5.0'
  bcr['passengerfile']['port'] = 8080
  bcr['passengerfile']['user'] = 'rundeck'
  bcr['passengerfile']['group'] = 'rundeck'
  bcr['ruby_bin'] = '/opt/chef/embedded/bin/ruby'
end

# recipe.rb
include_recipe 'simple_passenger'

@gsreynolds
Copy link
Contributor

(Related: #140, #102)

@gsreynolds
Copy link
Contributor

gsreynolds commented Nov 24, 2017

Quick brain dump/Note to self & others from our wrapper cookbook, for Chef 13 and for compatibility with how chef-rundeck translated chef node data to rundeck source config:

Until atheiman/better-chef-rundeck#31 is merged, use ev0ldave branch chef13.

# attributes.rb
default['passenger']['apps']['better-chef-rundeck'].tap do |bcr|
  bcr['git_repo'] = 'https://github.com/ev0ldave/better-chef-rundeck.git'
  bcr['git_revision'] = 'chef13'
  bcr['passengerfile']['port'] = 8080
  bcr['passengerfile']['user'] = 'rundeck'
  bcr['passengerfile']['group'] = 'rundeck'
  bcr['passengerfile']['envvars'] = { "BCR_CHEF_CONFIG": "/etc/chef/rundeck.rb" }
  bcr['ruby_bin'] = '/opt/chef/embedded/bin/ruby'
end
# recipe.rb
include_recipe 'simple_passenger'

By default better-chef-rundeck behaves differently to chef-rundeck in the attributes it returns, doesn't set hostname and nor a default username. Rundeck is unable to connect to remote nodes without these attributes.

chef-rundeck also translated the chef roles to rundeck tags for filtering and display in the UI, whereas better-chef-rundeck translates chef tags to rundeck tags (which is admittedly more correct but I'd argue less useful as at least from a personal point of view roles are more widely applied than tags in terms of grouping types of nodes).

"project_settings": {
  "resources.source.1.config.url": "http://localhost:8080/*:*?environment=chef_environment&hostname=fqdn&ip=ipaddress&run_list=run_list&roles=roles&platform=platform&tags=roles&default_username=rundeck"
}

(for reference: https://github.com/atheiman/better-chef-rundeck/blob/83f7d9bfbaaaff9e310e21788b846c6c294f0e07/lib/better_chef_rundeck.rb)

@PowerSchill
Copy link
Contributor

Quick brain dump/Note to self & others from our wrapper cookbook, for Chef 13 and for compatibility with how chef-rundeck translated chef node data to rundeck source config:

Until atheiman/better-chef-rundeck#31 is merged, use ev0ldave branch chef13.

# attributes.rb
default['passenger']['apps']['better-chef-rundeck'].tap do |bcr|
  bcr['git_repo'] = 'https://github.com/ev0ldave/better-chef-rundeck.git'
  bcr['git_revision'] = 'chef13'
  bcr['passengerfile']['port'] = 8080
  bcr['passengerfile']['user'] = 'rundeck'
  bcr['passengerfile']['group'] = 'rundeck'
  bcr['passengerfile']['envvars'] = { "BCR_CHEF_CONFIG": "/etc/chef/rundeck.rb" }
  bcr['ruby_bin'] = '/opt/chef/embedded/bin/ruby'
end
# recipe.rb
include_recipe 'simple_passenger'

By default better-chef-rundeck behaves differently to chef-rundeck in the attributes it returns, doesn't set hostname and nor a default username. Rundeck is unable to connect to remote nodes without these attributes.

chef-rundeck also translated the chef roles to rundeck tags for filtering and display in the UI, whereas better-chef-rundeck translates chef tags to rundeck tags (which is admittedly more correct but I'd argue less useful as at least from a personal point of view roles are more widely applied than tags in terms of grouping types of nodes).

"project_settings": {
  "resources.source.1.config.url": "http://localhost:8080/*:*?environment=chef_environment&hostname=fqdn&ip=ipaddress&run_list=run_list&roles=roles&platform=platform&tags=roles&default_username=rundeck"
}

(for reference: https://github.com/atheiman/better-chef-rundeck/blob/83f7d9bfbaaaff9e310e21788b846c6c294f0e07/lib/better_chef_rundeck.rb)

Are you still using this solution? When using simple_passenger I encounter atheiman/simple-passenger-cookbook#31

@mengesb
Copy link
Contributor

mengesb commented Feb 5, 2019

Until atheiman/better-chef-rundeck#31 is merged, use ev0ldave branch chef13.

Seems they made a replacement pull atheiman/better-chef-rundeck#35 -- does that make the world go round?

@mengesb
Copy link
Contributor

mengesb commented Feb 5, 2019

chef-rundeck also translated the chef roles to rundeck tags for filtering and display in the UI, whereas better-chef-rundeck translates chef tags to rundeck tags (which is admittedly more correct but I'd argue less useful as at least from a personal point of view roles are more widely applied than tags in terms of grouping types of nodes).

While I agree is there a way which we can provide a merge option ? merge roles and tags ; or just allow tags ? Or is that totally up to better-chef-rundeck?

I think working with a functional product is going to out-weigh working with a dead one; if we can give the user an option as to which to install great, however I'd rather adopt better-chef-rundeck as it is presently developed and not abandoned even if it is a shift -- should be noted

@PowerSchill PowerSchill added the Needs Triage Issue is waiting to be categorised label May 9, 2019
@damacus damacus added Feature Request Enhancement to existing functionality or new functionality Maintenance Maintenance issues such as failing builds and removed Needs Triage Issue is waiting to be categorised labels Aug 7, 2019
@damacus
Copy link
Member

damacus commented Aug 7, 2019

I think this seems like a sensible step and a pretty darn simple one. Once someone can work on the issue please go ahead!

@PowerSchill PowerSchill added Help Wanted Assistance is required to resolve this issue Waiting on Contributor Awaiting on the person who raised this to update labels Oct 14, 2019
@josephholsten
Copy link

FYI: @bscott is back at oswaldlabs/chef-rundeck#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Maintenance Maintenance issues such as failing builds Waiting on Contributor Awaiting on the person who raised this to update
Projects
None yet
Development

No branches or pull requests

7 participants